馃尡 Drop dependency on x/exp/slices #1567
Conversation
metal3-io-bot
added
the
size/XS
Go 1.21 already has what we need in the standard library. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
|
/test metal3-bmo-e2e-test-pull |
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
metal3-io-bot
added
size/S
|
/test metal3-bmo-e2e-test-pull |
|
I cannot reproduce the test failure locally. My best guess is something was not properly cleaned up between runs. |
| @@ -60,6 +59,7 @@ require ( | |||
| github.com/spf13/cobra v1.7.0 // indirect | |||
| github.com/spf13/pflag v1.0.5 // indirect | |||
| go.uber.org/multierr v1.11.0 // indirect | |||
| golang.org/x/exp v0.0.0-20230522175609-2e198f4a06a1 // indirect | |||
There was a problem hiding this comment.
Which module is still dependant on this?
There was a problem hiding this comment.
I'm not sure how to figure that out. Nothing in our code, I believe.
There was a problem hiding this comment.
go mod graph | grep "golang.org/x/exp" should give us the module which is using this.
There was a problem hiding this comment.
ok its coming from
k8s.io/apiextensions-apiserver@v0.28.3 and
sigs.k8s.io/controller-runtime@v0.16.3, so we cant really get rid of this entry.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Basically a cherry-pick from CAPM3 PR metal3-io#1567. Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes. Fix previous release tag pattern detection in Makefile. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
Basically a cherry-pick from CAPM3 PR metal3-io#1567. Support beta and RC releases in release note generator. Move some logic from Makefile to the release note generator, and then add nice unfolding summary section to hide details in beta/rc notes. Fix previous release tag pattern detection in Makefile. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
Go 1.21 already has what we need in the standard library.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com