Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add unit test on features.go #1579

Merged
merged 1 commit into from
Mar 5, 2024
Merged

🌱 Add unit test on features.go #1579

merged 1 commit into from
Mar 5, 2024

Conversation

lekaf974
Copy link
Contributor

@lekaf974 lekaf974 commented Mar 4, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1574

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 4, 2024
@metal3-io-bot
Copy link
Contributor

Hi @lekaf974. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 4, 2024
@dtantsur
Copy link
Member

dtantsur commented Mar 4, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
elfosardo
elfosardo reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

.gitignore Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Mar 4, 2024
lentzi90
lentzi90 reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
Some typos below

pkg/provisioner/ironic/clients/features_test.go Outdated Show resolved Hide resolved
pkg/provisioner/ironic/clients/features_test.go Outdated Show resolved Hide resolved
pkg/provisioner/ironic/clients/features_test.go Outdated Show resolved Hide resolved
@lentzi90 lentzi90 mentioned this pull request Mar 5, 2024
Open
7 tasks
@lekaf974 lekaf974 force-pushed the enhancement/improve-baremetal-test-coverage branch from acabba9 to e56f49f Compare March 5, 2024 11:19
lentzi90
lentzi90 reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
One more thing, could you please squash the commits?

@lekaf974
Add unit test on features.go
c4d8e2f 
Signed-off-by: mevrin <matthieu.evrin@gmail.com>
@lekaf974 lekaf974 force-pushed the enhancement/improve-baremetal-test-coverage branch from e56f49f to c4d8e2f Compare March 5, 2024 11:32
@tuminoid
Copy link
Member

tuminoid commented Mar 5, 2024

/test metal3-bmo-e2e-test-pull

@tuminoid
Copy link
Member

tuminoid commented Mar 5, 2024

/override test-centos-e2e-integration-main
Unit test addition, skip.

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: test-centos-e2e-integration-main

In response to this:

/override test-centos-e2e-integration-main
Unit test addition, skip.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tuminoid
tuminoid reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@metal3-io-bot metal3-io-bot merged commit 15e7d73 into metal3-io:main Mar 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@elfosardo elfosardo elfosardo left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test coverage improvement in BMO
6 participants
@lekaf974 @metal3-io-bot @tuminoid @dtantsur @lentzi90 @elfosardo