New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 add golang base image check to verify-release.sh #1614
馃尡 add golang base image check to verify-release.sh #1614
Conversation
/hold |
/override metal3-bmo-e2e-test-pull test-centos-e2e-integration-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make verify-release.sh check also if the golang base image is most recent of the minor series. Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
1c42a76
to
f513e50
Compare
Updated to support Mac users: grep -P doesn't exist in Mac's BSD based grep. /override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, Rozzii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.5 |
/cherry-pick release-0.4 |
@tuminoid: new pull request created: #1617 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tuminoid: new pull request created: #1618 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Make verify-release.sh check also if the golang base image is most recent of the minor series.
I'll cherry-pick it to release branches.