Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 add golang base image check to verify-release.sh #1614

Merged
merged 1 commit into from Mar 12, 2024

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Mar 8, 2024

Make verify-release.sh check also if the golang base image is most recent of the minor series.

I'll cherry-pick it to release branches.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/cc @dtantsur @elfosardo @lentzi90

@tuminoid
Copy link
Member Author

tuminoid commented Mar 8, 2024

/override metal3-bmo-e2e-test-pull test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main

In response to this:

/override metal3-bmo-e2e-test-pull test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Make verify-release.sh check also if the golang base image is most
recent of the minor series.

Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@tuminoid
Copy link
Member Author

Updated to support Mac users: grep -P doesn't exist in Mac's BSD based grep.

/override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main

In response to this:

Updated to support Mac users: grep -P doesn't exist in Mac's BSD based grep.

/override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@tuminoid
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Rozzii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 4cfd776 into metal3-io:main Mar 12, 2024
17 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-base-image-check branch March 12, 2024 09:22
@tuminoid
Copy link
Member Author

/cherry-pick release-0.5

@tuminoid
Copy link
Member Author

/cherry-pick release-0.4

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1617

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

@tuminoid: new pull request created: #1618

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants