Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Remove ibmc and idrac drivers #1624

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

dtantsur
Copy link
Member

Both drivers (in case of idrac - its wsman implementation) has been
unmaintained for years, same for their underlying libraries ibmcclient [1]
and dracclient [2]. Ironic has deprecated them in the 2024.1 cycle.

Dell users should use idrac-redfish:// and idrac-virtualmedia:// instead.
iBMC users should try using the generic Redfish drivers and report any
bugs to the Ironic team and any standard compatibility problems directly
to Huawei.

[1] https://github.com/IamFive/python-ibmcclient
[2] https://opendev.org/openstack/python-dracclient

Both drivers (in case of idrac - its wsman implementation) has been
unmaintained for years, same for their underlying libraries ibmcclient [1]
and dracclient [2]. Ironic has deprecated them in the 2024.1 cycle.

Dell users should use idrac-redfish:// and idrac-virtualmedia:// instead.
iBMC users should try using the generic Redfish drivers and report any
bugs to the Ironic team and any standard compatibility problems directly
to Huawei.

[1] https://github.com/IamFive/python-ibmcclient
[2] https://opendev.org/openstack/python-dracclient

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 18, 2024
@dtantsur
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@honza
Copy link
Member

honza commented Mar 25, 2024

Do we need some kind of deprecation notice?

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@metal3-io-bot metal3-io-bot merged commit 21f3480 into metal3-io:main Mar 25, 2024
18 checks passed
@tuminoid
Copy link
Member

Do we need some kind of deprecation notice?

Wouldn't any deprecation notice needed to be in previous release already?

@dtantsur dtantsur deleted the deprecate-drivers branch March 26, 2024 09:04
@dtantsur
Copy link
Member Author

I hoped that my ML thread would serve as a deprecation notice. Given the state of the drivers, I did not want to make the process too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants