Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 remove obsolete Makefile related gofmt, gosec scripts #1632

Merged
merged 1 commit into from Mar 26, 2024
Merged

馃尡 remove obsolete Makefile related gofmt, gosec scripts #1632

merged 1 commit into from Mar 26, 2024

Conversation

tico88612
Copy link
Contributor

What this PR does / why we need it:

  • Remove Makefile related gofmt gosec scripts

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1628

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2024
@metal3-io-bot
Copy link
Contributor

Hi @tico88612. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 25, 2024
tuminoid
tuminoid requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to tremove fmt-check from L131 and L170 too.

@tico88612
Remove: Makefile related gofmt gosec scripts
2e2666c 
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 requested a review from tuminoid March 25, 2024 11:21
@tuminoid
Copy link
Member

/retitle 馃尡 remove obsolete Makefile related gofmt, gosec scripts

@metal3-io-bot metal3-io-bot changed the title 馃尡 Remove: Makefile related gofmt gosec scripts 馃尡 remove obsolete Makefile related gofmt, gosec scripts Mar 25, 2024
tuminoid
tuminoid reviewed Mar 25, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contribution!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@tuminoid
Copy link
Member

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@tico88612
Copy link
Contributor Author

It looks like it's stuck on a missing approve label.

image

@tuminoid
Copy link
Member

It looks like it's stuck on a missing approve label.

To merge a PR in Metal3, you need LGTM and approval from different persons. An approver will review this soon.

@tuminoid
Copy link
Member

/assign @kashifest

@kashifest
Copy link
Member

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit 4f45b88 into metal3-io:main Mar 26, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid approved these changes

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove gofmt make targets and script
4 participants
@tico88612 @metal3-io-bot @tuminoid @kashifest