🌱 Update ironic basic-auth-tls overlay #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
mquhuy
force-pushed
the
mquhuy/make-sure-ironic-basic-auth-tls-overlay-works
branch
from
ffdb435
to
b183d66
Compare
mquhuy
force-pushed
the
mquhuy/make-sure-ironic-basic-auth-tls-overlay-works
branch
from
b183d66
to
9cba944
Compare
metal3-io-bot
added
size/S
Signed-off-by: Huy Mai <huy.mai@est.tech>
mquhuy
force-pushed
the
mquhuy/make-sure-ironic-basic-auth-tls-overlay-works
branch
from
9cba944
to
ef52552
Compare
metal3-io-bot
added
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test metal3-bmo-e2e-test-pull |
metal3-io-bot
deleted the
mquhuy/make-sure-ironic-basic-auth-tls-overlay-works
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added some comments to instruct secret and configmap generation for
ironic-deployment/overlays/basic-auth_tlsoverlay