Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Remove redundant deploy instruction #1652

Merged
merged 1 commit into from Apr 3, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Apr 2, 2024

What this PR does / why we need it:
The deploy.md is actually a clone of a section in metal3 book. We should remove it to eliminate the chance of diversion.

Signed-off-by: Huy Mai <huy.mai@est.tech>
@mquhuy mquhuy force-pushed the mquhuy/remove-redundant-docs branch from e869bd7 to 244e274 Compare April 2, 2024 13:26
@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 2, 2024
@dtantsur
Copy link
Member

dtantsur commented Apr 3, 2024

/approve

Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lentzi90
Copy link
Member

lentzi90 commented Apr 3, 2024

Hehe race condition approval 😄
I'll switch to lgtm then
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@lentzi90
Copy link
Member

lentzi90 commented Apr 3, 2024

/override metal3-bmo-e2e-test-pull
/override test-centos-e2e-integration-main

@metal3-io-bot
Copy link
Contributor

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main

In response to this:

/override metal3-bmo-e2e-test-pull
/override test-centos-e2e-integration-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot merged commit dcb543b into metal3-io:main Apr 3, 2024
13 checks passed
@metal3-io-bot metal3-io-bot deleted the mquhuy/remove-redundant-docs branch April 3, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants