Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Make use of the new liveness/readiness probe scripts #1657

Merged
merged 1 commit into from Apr 8, 2024

Conversation

dtantsur
Copy link
Member

@dtantsur dtantsur commented Apr 8, 2024

Using them allows us not to care about all possible ways Ironic can be
installed. In the future, we can use the mounted secrets to exercise
less trivial API resources such as conductors or drivers
(see #1528).

Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com

Using them allows us not to care about all possible ways Ironic can be
installed. In the future, we can use the mounted secrets to exercise
less trivial API resources such as conductors or drivers
(see metal3-io#1528).

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 8, 2024
@dtantsur
Copy link
Member Author

dtantsur commented Apr 8, 2024

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main

@dtantsur dtantsur requested a review from tuminoid April 8, 2024 13:05
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@honza
Copy link
Member

honza commented Apr 8, 2024

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@metal3-io-bot metal3-io-bot merged commit c7aa4ae into metal3-io:main Apr 8, 2024
17 checks passed
@dtantsur dtantsur deleted the probes branch April 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants