Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 Pinning ironic image release-24.1 #1679

Merged
merged 1 commit into from Apr 17, 2024

Conversation

adilGhaffarDev
Copy link
Member

What this PR does / why we need it:
as title
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: adil ghaffar <muhammad.adil.ghaffar@est.tech>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@adilGhaffarDev
Copy link
Member Author

/test ?

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The following commands are available to trigger required jobs:

  • /test manifestlint
  • /test shellcheck

Use /test all to run the following jobs that were automatically triggered:

  • manifestlint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adilGhaffarDev
Copy link
Member Author

/test metal3-bmo-e2e-test-pull

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test manifestlint
  • /test shellcheck

Use /test all to run the following jobs that were automatically triggered:

  • manifestlint

In response to this:

/test metal3-bmo-e2e-test-pull

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adilGhaffarDev
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@adilGhaffarDev
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@metal3-io-bot metal3-io-bot merged commit c463618 into metal3-io:release-0.6 Apr 17, 2024
12 checks passed
@metal3-io-bot metal3-io-bot deleted the pin-ironic/adil branch April 17, 2024 11:55
@sathieu
Copy link
Contributor

sathieu commented Apr 29, 2024

@adilGhaffarDev Why are you pinning only the dnsmasq container and not the others?

@adilGhaffarDev
Copy link
Member Author

@adilGhaffarDev Why are you pinning only the dnsmasq container and not the others?

sorry, it was missed. I have opened the PR: #1707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants