Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 Add Slack notification for image build workflow failure #1687

Merged
merged 1 commit into from
Apr 25, 2024
Merged

馃尡 Add Slack notification for image build workflow failure #1687

merged 1 commit into from
Apr 25, 2024

Conversation

NymanRobin
Copy link
Member

@NymanRobin NymanRobin commented Apr 19, 2024 •
edited
Loading

Adds Slack notification for EST internal teams slack channel for jobs that run on merge.
This is so a wider audience can more quickly detect failures.

Sadly, this is currently only EST internal hopefully if this works out well we can find a solution were all interested can partake

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@NymanRobin NymanRobin marked this pull request as draft April 19, 2024 10:17
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2024
@NymanRobin NymanRobin force-pushed the add-slack-notification-for-gh-actions branch from 6973db3 to c8c1718 Compare April 19, 2024 10:27
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2024
@NymanRobin NymanRobin force-pushed the add-slack-notification-for-gh-actions branch from c8c1718 to 1aeac8f Compare April 23, 2024 05:35
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2024
@NymanRobin NymanRobin changed the title 馃尡 WIP:Add Slacks notification for GH actions 馃尡 Add Slacks notification for GH actions Apr 23, 2024
@NymanRobin NymanRobin marked this pull request as ready for review April 23, 2024 06:10
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
mquhuy
mquhuy reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@mquhuy mquhuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a nit/sugggestion

Edit: The suggestion is not needed, the action in use already handled

.github/workflows/build-images-action.yml Show resolved Hide resolved
@NymanRobin
Add Slacks notification for GH actions
c3645a3 
Adds Slack notification for EST internal teams
slack channel for jobs that run on push.
So a wider audience can more quickly
detect failures.

Signed-off-by: NymanRobin <robin.nyman@est.tech>
@NymanRobin NymanRobin force-pushed the add-slack-notification-for-gh-actions branch from 1aeac8f to c3645a3 Compare April 23, 2024 07:47
@tuminoid
Copy link
Member

/retitle 馃尡 Add Slack notification for build images workflow failure

@metal3-io-bot metal3-io-bot changed the title 馃尡 Add Slacks notification for GH actions 馃尡 Add Slack notification for build images workflow failure Apr 23, 2024
@tuminoid
Copy link
Member

Is there any way to test it before merging?

@NymanRobin
Copy link
Member Author

NymanRobin commented Apr 23, 2024 •
edited
Loading

Testing it is quite hard @tuminoid

What I have done is that I have ran it locally with https://github.com/nektos/act the result of these runs can be seen in the channel.

To run test we would have to force failure in the pipeline and since this is push trigger we it would be on a merged change which is not ideal. We could of course change trigger to run pull-request but then again github won't allow usage of secrets in github action workflows triggered from forks. So maybe forcing a failure, in the pipeline with changed trigger in a branch created by an admin would be the test that I can think of. But honestly I do not see how that is so much different to running it locally

tuminoid
tuminoid reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2024
@tuminoid
Copy link
Member

/override metal3-bmo-e2e-test-pull metal3-centos-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-bmo-e2e-test-pull, metal3-centos-e2e-integration-test-main

In response to this:

/override metal3-bmo-e2e-test-pull metal3-centos-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tuminoid
Copy link
Member

/assign @kashifest

kashifest
kashifest reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@tuminoid
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 25, 2024
@tuminoid
Copy link
Member

/retitle 馃尡 Add Slack notification for image build workflow failure
tide workaround

@metal3-io-bot metal3-io-bot changed the title 馃尡 Add Slack notification for build images workflow failure 馃尡 Add Slack notification for image build workflow failure Apr 25, 2024
@metal3-io-bot metal3-io-bot merged commit 1d9a89a into metal3-io:main Apr 25, 2024
29 checks passed
@metal3-io-bot metal3-io-bot deleted the add-slack-notification-for-gh-actions branch April 25, 2024 08:15
@NymanRobin NymanRobin mentioned this pull request May 16, 2024
Closed
@NymanRobin
Copy link
Member Author

/cherry-pick release-0.6

@NymanRobin
Copy link
Member Author

/cherry-pick release-0.5

@metal3-io-bot
Copy link
Contributor

@NymanRobin: new pull request created: #1741

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 22, 2024
Merged
Merged
@metal3-io-bot
Copy link
Contributor

@NymanRobin: new pull request created: #1742

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@mquhuy mquhuy mquhuy left review comments

@kashifest kashifest kashifest left review comments

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NymanRobin @tuminoid @metal3-io-bot @mquhuy @kashifest