Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fasttrack for ironic #394

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Enable fasttrack for ironic #394

merged 1 commit into from
Jan 24, 2020

Conversation

maelk
Copy link
Member

@maelk maelk commented Jan 20, 2020

the fix was merged upstream and is in the tripleO package:
https://opendev.org/openstack/ironic/commit/7f1f79ac25e270c3585dd23c042a037431b97718

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@maelk
Copy link
Member Author

maelk commented Jan 20, 2020

/test-integration

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@Xenwar
Copy link
Member

Xenwar commented Jan 20, 2020

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@maelk
Copy link
Member Author

maelk commented Jan 20, 2020

/hold
The bug upstream is actually not fully fixed yet : https://review.opendev.org/#/c/703160/

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@maelk
Copy link
Member Author

maelk commented Jan 21, 2020

/test-integration

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@maelk
Copy link
Member Author

maelk commented Jan 24, 2020

/test-integration

@maelk
Copy link
Member Author

maelk commented Jan 24, 2020

/hold cancel
The Ironic fix is in!

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2020
@Xenwar
Copy link
Member

Xenwar commented Jan 24, 2020

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@metal3-io-bot metal3-io-bot merged commit 6ae8d7e into metal3-io:master Jan 24, 2020
@smoshiur1237 smoshiur1237 deleted the fasttrack-mael branch October 5, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Xenwar Xenwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maelk @metal3-io-bot @Xenwar