-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Pause annotation for pivoting #438
Conversation
/cc @dhellmann |
/test-integration |
6f77382
to
2a14b84
Compare
/test-integration |
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
When pivoting, we need a way to temporarily disable the reconciliation of objects while we are moving them. The BMH status needs to be moved along with the spec, and that is a two-step operation (create the BMH and update the status). If the reconciliation was happening in the meantime, this could trigger an introspection of a deployed host, hence messing up the host. Adding the annotation on the BMH would prevent such issues.