Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operator-sdk #487

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Update operator-sdk #487

merged 2 commits into from
Apr 27, 2020

Conversation

honza
Copy link
Member

@honza honza commented Apr 22, 2020

  • Upgrade to v0.17.0
  • Use openapi-gen directly because the original command is deprecated

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 22, 2020
@stbenjam
Copy link
Member

/test-integration

@stbenjam
Copy link
Member

/test-integration

Copy link
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with hack/boilerplate.go.txt? Is that meant to be empty?

Is #484 a prerequisite for this?

operator-sdk removed the openapi generation command in v0.17.0.
@honza
Copy link
Member Author

honza commented Apr 27, 2020

What's up with hack/boilerplate.go.txt? Is that meant to be empty?

Good point; I have set it to /dev/null. It's empty because we don't currently have any file headers.

Is #484 a prerequisite for this?

No, they are independent and both necessary.

@stbenjam
Copy link
Member

/test-integration

@stbenjam
Copy link
Member

/approve
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@metal3-io-bot metal3-io-bot merged commit 7ce3ae1 into metal3-io:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants