🏃 Change configMapGenerator behavior in kustomization and typo fixes #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
furkatgofurov7
force-pushed
the
furkat-confmap-behavior-fix
branch
from
5be982b
to
012d0d8
Compare
metal3-io-bot
added
size/S
|
/test-integration |
|
/cc @maelk |
furkatgofurov7
changed the title
furkatgofurov7
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This patch fixes configMapGenerator behavior so that when BMO is deployed as part of CAPM3 it needs to be able to
createconfigmap rather thanmergeand also addresses few fixes to some comments (typo and rephrasing) in #541Logs:
Error: accumulating resources: accumulateFile "accumulating resources from '../deploy/default': '/home/****/go/src/github.com/metal3-io/baremetal-operator/deploy/default' must resolve to a file", accumulateDirector: "recursed accumulation of path '/home/****/go/src/github.com/metal3-io/baremetal-operator/deploy/default': merging from generator &{0xc0007bb230 { } {{ ironic-bmo-configmap merge {[] [] [ironic_bmo_configmap.env]} <nil>}}}: id resid.ResId{Gvk:resid.Gvk{Group:\"\", Version:\"v1\", Kind:\"ConfigMap\"}, Name:\"ironic-bmo-configmap\", Namespace:\"\"} does not exist; cannot merge or replace"Related to: /metal3-dev-env/pull/338