Update Ironic Keepalived container documentation #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/M
kashifest
force-pushed
the
update/ironic-keepalived-documentation
branch
from
c1e8b67
to
2eb2d76
Compare
|
/assign @maelk |
|
/test-integration |
maelk
approved these changes
Jun 22, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
| URL is used with `ironic-keepalived-config/image_patch.yaml` to replace the | ||
| default image URL with the correct URL through kustomization. | ||
| URL is used with `ironic-deployment/keepalived/keepalived_patch.yaml` to replace | ||
| the default image URL with the correct URL through kustomization. | ||
|
|
||
| **Important Note** |
There was a problem hiding this comment.
I forgot to add, Important Note part is already included in deploying.md, do we need to keep this here as well?
There was a problem hiding this comment.
I don't see any harm. I would rather keep it here specially since the variables are expected for this container.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kustomization workflow has changed significantly and the different deployment scenarios have also been updated. This PR removes the obsolete info from Ironic Keepalived container documentation and also updates the documentation with the way it should be deployed now.