add -boot-mode argument to make-bm-worker

[dhellmann]

metal3-dev-env uses this program to create host resources. In order to
let metal3-dev-env change the boot mode for hosts, we need to add an
option to pass the value through to the template.

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhellmann]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stbenjam]

/lgtm

[stbenjam]

/test-integration

[maelk]

This failed because the boot mode is not specified in the command line :

go run /home/****/tested_repo/cmd/make-bm-worker/main.go -address ipmi://192.168.111.1:6230 -password password -user admin -boot-mac 00:6a:7d:7c:4c:98 node-0
Invalid boot mode "", use "UEFI" or "legacy"
exit status 1

Should it default to legacy ?

[dhellmann]

This failed because the boot mode is not specified in the command line :

go run /home/****/tested_repo/cmd/make-bm-worker/main.go -address ipmi://192.168.111.1:6230 -password password -user admin -boot-mac 00:6a:7d:7c:4c:98 node-0
Invalid boot mode "", use "UEFI" or "legacy"
exit status 1

Should it default to legacy ?

I assumed the variable would be nil if not specified on the command line. I've fixed the test.

We want the default to be empty here, to allow the baremetal-operator to control the default. The plan there is to use UEFI as the default, which is why metal3-io/metal3-dev-env#395 sets the value to legacy explicitly so our CI will work.

[stbenjam]

/test-integration

[maelk]

/lgtm