Add missing ironic bmo configmap in config/default #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
kashifest
force-pushed
the
add/missing-ironic-configmap
branch
from
dd7a1ad
to
939cf70
Compare
metal3-io-bot
added
size/M
|
/test-integration |
kashifest
force-pushed
the
add/missing-ironic-configmap
branch
from
939cf70
to
e8594b9
Compare
kashifest
force-pushed
the
add/missing-ironic-configmap
branch
from
e8594b9
to
10dcca8
Compare
maelk
approved these changes
Oct 9, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
This won't pass the CI. I'll manually merge for now and we'll fix the CAPM3 side based on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing ironic_bmo_configmap file and missing kustomization entry in config/default directory