Get correct image checksum in getImageUpdateOptsForNode() #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always want to get the checksum from the Image passed as imageData. Due to an inadvertant change during the refactoring that created this method (177d9ef), we were always getting the checksum from the Image in the Spec, even though imageData may reference the one in the Status during registration. This meant that during deprovisioning (with no image in the Spec), adoption would fail as the node would not have image data added during registration.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test-v1a3-centos-integration |
metal3-io-bot
added
the
size/XS
|
Thanks for spotting this, not sure how/why I made that mistake! 🤔 /lgtm |
hardys
pushed a commit
to hardys/baremetal-operator
that referenced
this pull request
Jan 19, 2021
As seen in the regression CI discovered that prompted metal3-io#768 we're missing some test coverage of the two possible image sources in ValidateManagementAccess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always want to get the checksum from the Image passed as imageData.
Due to an inadvertant change during the refactoring that created this
method (177d9ef), we were always
getting the checksum from the Image in the Spec, even though imageData
may reference the one in the Status during registration.
This meant that during deprovisioning (with no image in the Spec),
adoption would fail as the node would not have image data added during
registration.