Don't immediately retry on Inspect fail #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
approved
s3rj1k
reviewed
Mar 30, 2021
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s3rj1k, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In the patch 2d02462 we were supposed to report an error and wait for an exponentially increasing backoff time before retrying. However, due to a missing early return, we are retrying immediately with the result that the error gets cleared in fairly short order. Return early on failure as intended. Also, use the operationFailed() convenience function instead of ad hoc updates to the return variables; this case was likely missed due to the lack of a return.
Apparently this is a thing.
zaneb
force-pushed
the
inspect-fail-delay
branch
from
6c48c93
to
e8f1598
Compare
metal3-io-bot
added
size/M
|
/test-integration |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that if the ironic node enters the InspectFail state, we not only report the error but also wait until after the exponential backoff before retrying, instead of retrying immediately.
The previous attempt to fix this in 2d02462 didn't take due to a missing return.