Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod for BMH api #857

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Add go.mod for BMH api #857

merged 1 commit into from
Apr 16, 2021

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Apr 15, 2021

This PR adds go.mod for BMH api.

The reason to add the go module in api is to uplift BMO for CAPM3 without requiring controller runtime to be uplifted to > 0.5.14 which is the version currently supported by CAPI.

Important:
Once this PR goes in, those who need to uplift BMO, and they are only using BMO apis , you need to change you go modules to use

github.com/metal3-io/baremetal-operator/apis instead of
github.com/metal3-io/baremetal-operator

If you are using/referring other parts of code in BMO not residing in apis/, you need to use both the modules

github.com/metal3-io/baremetal-operator
github.com/metal3-io/baremetal-operator/apis

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 15, 2021
@kashifest
Copy link
Member Author

/assign @dhellmann
/cc @maelk @zaneb

@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2021
@kashifest kashifest force-pushed the addGoMoDApi branch 2 times, most recently from b11807f to 8115eb2 Compare April 15, 2021 11:43
@dhellmann
Copy link
Member

Can we put the module in the /apis directory so that if we add more APIs later and when we inevitably update the version (we've been v1a1 for way too long) we can avoid adding more modules?

@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 15, 2021
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2021
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 15, 2021
@kashifest
Copy link
Member Author

Can we put the module in the /apis directory so that if we add more APIs later and when we inevitably update the version (we've been v1a1 for way too long) we can avoid adding more modules?

Agreed. Good point. I have changed it. Please take a look.

@kashifest
Copy link
Member Author

/test-integration
/test-centos-integration

@kashifest
Copy link
Member Author

/test-integration
/test-centos-integration

@zaneb
Copy link
Member

zaneb commented Apr 15, 2021

No idea how this multiple modules stuff works, but I support the goal and this looks as plausible as anything :)
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@kashifest
Copy link
Member Author

/test-centos-integration

@kashifest
Copy link
Member Author

/test-centos-integration

@maelk
Copy link
Member

maelk commented Apr 16, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2021
@maelk maelk merged commit c927d1d into metal3-io:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants