-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go.mod for BMH api #857
Conversation
/assign @dhellmann |
b11807f
to
8115eb2
Compare
Can we put the module in the |
Agreed. Good point. I have changed it. Please take a look. |
/test-integration |
/test-integration |
No idea how this multiple modules stuff works, but I support the goal and this looks as plausible as anything :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test-centos-integration |
/test-centos-integration |
/lgtm |
This PR adds go.mod for BMH api.
The reason to add the go module in api is to uplift BMO for CAPM3 without requiring controller runtime to be uplifted to > 0.5.14 which is the version currently supported by CAPI.
Important:
Once this PR goes in, those who need to uplift BMO, and they are only using BMO apis , you need to change you go modules to use
github.com/metal3-io/baremetal-operator/apis
instead ofgithub.com/metal3-io/baremetal-operator
If you are using/referring other parts of code in BMO not residing in
apis/
, you need to use both the modules