-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add unit and lint test in travis" #869
Conversation
fmuyassarov
commented
May 2, 2021
•
edited
edited
- This reverts Add unit and lint test in travis #862 as Prow cluster is back on track and disables unit & linting test.
- Fixes shellcheck issue in the existing scripts
/hold |
I noticed unrelated shellcheck failure, it seems while Prow was down we missed a bug related to shell linting. I will fix the issue in this PR if that's okay.
|
f86d21d
to
514cd50
Compare
Actually by looking at the history we have this issue for a quite long time, not sure why shellcheck started complaining only now. |
/test-integration |
Don't assigne variable is to itself. Reference: https://github.com/koalaman/shellcheck/wiki/SC2269
514cd50
to
e0aa706
Compare
/test-integration |
/unhold |
/lgtm |
/cc @maelk |
Looks good to me. |
/lgtm |
@s3rj1k: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/cc @zaneb @dhellmann |
LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, fmuyassarov, s3rj1k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |