Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add unit and lint test in travis" #869

Merged
merged 2 commits into from
May 3, 2021

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented May 2, 2021

  1. This reverts Add unit and lint test in travis #862 as Prow cluster is back on track and disables unit & linting test.
  2. Fixes shellcheck issue in the existing scripts

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2021
@fmuyassarov
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2021
@fmuyassarov
Copy link
Member Author

fmuyassarov commented May 2, 2021

I noticed unrelated shellcheck failure, it seems while Prow was down we missed a bug related to shell linting. I will fix the issue in this PR if that's okay.

+ IS_CONTAINER=TRUE
+ CONTAINER_RUNTIME=podman
+ '[' TRUE '!=' false ]
+ TOP_DIR=.
+ find . '(' -path ./vendor -prune ')' -o -name '*.sh' -exec shellcheck -s bash '{}' +

In ./tools/deploy.sh line 21:
IRONIC_HOST="${IRONIC_HOST}"
^---------^ SC2269: This variable is assigned to itself, so the assignment does nothing.


In ./tools/deploy.sh line 22:
IRONIC_HOST_IP="${IRONIC_HOST_IP}"
^------------^ SC2269: This variable is assigned to itself, so the assignment does nothing.

For more information:
  https://www.shellcheck.net/wiki/SC2269 -- This variable is assigned to itse...

@fmuyassarov
Copy link
Member Author

I noticed unrelated shellcheck failure, it seems while Prow was down we missed a bug related to shell linting. I will fix the issue in this PR if that's okay.

Actually by looking at the history we have this issue for a quite long time, not sure why shellcheck started complaining only now.

@fmuyassarov
Copy link
Member Author

/test-integration

@fmuyassarov fmuyassarov requested a review from kashifest May 2, 2021 17:13
@fmuyassarov
Copy link
Member Author

/test-integration

@fmuyassarov
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2021
@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2021
@fmuyassarov
Copy link
Member Author

/cc @maelk

@metal3-io-bot metal3-io-bot requested a review from maelk May 3, 2021 07:11
@smoshiur1237
Copy link
Member

Looks good to me.

@s3rj1k
Copy link
Member

s3rj1k commented May 3, 2021

/lgtm

@metal3-io-bot
Copy link
Contributor

@s3rj1k: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@s3rj1k
Copy link
Member

s3rj1k commented May 3, 2021

/approve

@fmuyassarov
Copy link
Member Author

/cc @zaneb @dhellmann

@namnx228
Copy link
Member

namnx228 commented May 3, 2021

LGTM

@dtantsur
Copy link
Member

dtantsur commented May 3, 2021

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, fmuyassarov, s3rj1k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@metal3-io-bot metal3-io-bot merged commit 0c1ede9 into metal3-io:master May 3, 2021
@fmuyassarov fmuyassarov deleted the disable-travis/feruz branch May 3, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants