Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift kube-rbac-proxy to v0.8.0 #891

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Uplift kube-rbac-proxy to v0.8.0 #891

merged 1 commit into from
Jun 4, 2021

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented May 24, 2021 •
edited

Taking in changes as CAPI release-0.3 kubernetes-sigs/cluster-api#4639
Eventually this means only to take a newer version of kube-rbac-proxy into effect.

@kashifest
Copy link
Member Author

/test-integration

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2021
@jan-est
Copy link
Member

jan-est commented May 24, 2021

/lgtm

@metal3-io-bot
Copy link
Contributor

@jan-est: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kashifest
Copy link
Member Author

/assign @zaneb
/cc @dhellmann @fmuyassarov @furkatgofurov7

@dtantsur
Copy link
Member

dtantsur commented Jun 2, 2021

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@jan-est
Copy link
Member

jan-est commented Jun 4, 2021

/lgtm

@metal3-io-bot
Copy link
Contributor

@jan-est: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

furkatgofurov7
furkatgofurov7 reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2021
@metal3-io-bot metal3-io-bot merged commit d5e09a6 into metal3-io:master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@dhellmann dhellmann Awaiting requested review from dhellmann

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

@zaneb zaneb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kashifest @jan-est @metal3-io-bot @dtantsur @furkatgofurov7 @zaneb