Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kashifest and fmuyassarov as approvers #963

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add kashifest and fmuyassarov as approvers #963

merged 1 commit into from
Sep 2, 2021

Conversation

fmuyassarov
Copy link
Member

Add @kashifest and @fmuyassarov as approvers in the following directories

/config
/ironic-deployment
/resources
/tools

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2021
@fmuyassarov
Copy link
Member Author

/cc @dtantsur @hardys @maelk @stbenjam @zaneb
/test-integration

@dtantsur
Copy link
Member

dtantsur commented Sep 2, 2021

/lgtm

Congrats!

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@dtantsur
Copy link
Member

dtantsur commented Sep 2, 2021

I assume we don't need to duplicate the main OWNERS in these files?

@fmuyassarov
Copy link
Member Author

I assume we don't need to duplicate the main OWNERS in these files?

I think no, because root OWNERS takes privilege over all other OWNERS file I believe.

@zaneb
Copy link
Member

zaneb commented Sep 2, 2021

I'd have been inclined to put the /resources/keepalived-docker up a level in /resources, but it's academic for now.
/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2021
@metal3-io-bot metal3-io-bot merged commit 3782bde into metal3-io:master Sep 2, 2021
@fmuyassarov fmuyassarov deleted the extent-owners/feruz branch November 19, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur Awaiting requested review from dtantsur

@hardys hardys Awaiting requested review from hardys

@maelk maelk Awaiting requested review from maelk

@stbenjam stbenjam Awaiting requested review from stbenjam

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fmuyassarov @dtantsur @zaneb @metal3-io-bot