Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 Update docs and add more context concerning new deployment folders #972

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

furkatgofurov7
Copy link
Member

Updates tree structure for config/, ironic-deployment/ and resources/keepalived-docker/ folders. Also adds some more information re: what and why do we need those new folders/deployment files.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2021
@furkatgofurov7
Copy link
Member Author

/assign @zaneb
/cc @maelk @kashifest
/test-integration

@fmuyassarov
Copy link
Member

LGTM

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2021
@furkatgofurov7
Copy link
Member Author

/cc @dtantsur @andfasano

@andfasano
Copy link
Member

/lgtm

@dtantsur
Copy link
Member

dtantsur commented Sep 9, 2021

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2021
@metal3-io-bot metal3-io-bot merged commit b6d8b51 into metal3-io:master Sep 9, 2021
@furkatgofurov7 furkatgofurov7 deleted the update-docs/furkat branch September 23, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants