This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
✨ Add default, validation and conversion webhooks #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
approved
|
/cc @kashifest |
metal3-io-bot
requested review from
fmuyassarov,
Jaakko-Os,
jan-est and
kashifest
|
/test-v1a3-integration |
maelk
force-pushed
the
v1alpha3-mael
branch
2 times, most recently
from
545bddb
to
429078f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan-est, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- add conversion-gen output for v1alpha2 - add conversion functions for v1alpha2 - add webhooks for v1alpha2
adds the webhooks deployment
Now runs a controller for webhooks and a controller for reconciliation Use Go 1.13
and update kustomize and kubebuilder install scripts
kashifest
reviewed
Feb 18, 2020
| @@ -36,10 +36,10 @@ import ( | |||
| "k8s.io/utils/pointer" | |||
|
|
|||
| bmh "github.com/metal3-io/baremetal-operator/pkg/apis/metal3/v1alpha1" | |||
| capbm "github.com/metal3-io/cluster-api-provider-baremetal/api/v1alpha3" | |||
There was a problem hiding this comment.
I think we should use infrav1 in all places to be more consistent.
| c.Default() | ||
| } | ||
|
|
||
| func TestBareMetalMachineTemplateValidation(t *testing.T) { |
There was a problem hiding this comment.
Should we only check Image for validation? No other fields to check?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds for BareMetalCluster, BareMetalMachine and BareMetalMachineTemplate:
It also upgrade the CRD version to v1, and controller-gen to v0.2.5