Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Update v1a3 CRDs to add image checksum type and disk format #103

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

maelk
Copy link
Member

@maelk maelk commented Jun 18, 2020

What this PR does / why we need it:
This PR adds the image checksum type and disk format in v1a3 CRDs, as it was added in release-0.3 branch.
This also limits the disk formats accepted to match BMO's.

as it was added in release-0.3 branch.
This also limits the disk formats accepted to match BMO's.
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2020
@maelk
Copy link
Member Author

maelk commented Jun 18, 2020

This requires metal3-io/metal3-dev-env#346 to be able to run the integration tests

@maelk
Copy link
Member Author

maelk commented Jun 18, 2020

/test generate

@maelk
Copy link
Member Author

maelk commented Jun 18, 2020

/test unit

@furkatgofurov7
Copy link
Member

/test-v1a4-integration

@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020
@metal3-io-bot metal3-io-bot merged commit 14e6efd into metal3-io:master Jun 23, 2020
@kashifest kashifest deleted the fix-mael branch June 20, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants