-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Update namings in images #119
Conversation
/test-v1a4-integration |
/assign @maelk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tiny comment, is it still possible to rewrite CAPM³ to CAPM3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maybe agree on the spelling of the acronym. Until now we have been using more CAPM3 I would say
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fmuyassarov I was following this and this to keep consistency, in that case we have to change these as well to CAPM3? I can rewrite CAPM3 only in my patch as well. |
Agree, here we have |
In those docs, it is only Metal³, but not CAPM³. So, as you said for the sake of consistency maybe we could use CAPM3? |
Sure, fixed |
4b4389b
to
bba4dca
Compare
/test-v1a4-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Updates old namings in images
Relevant to #118