Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Update namings in images #119

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:
Updates old namings in images

Relevant to #118

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2020
@furkatgofurov7
Copy link
Member Author

/test-v1a4-integration

@furkatgofurov7
Copy link
Member Author

/assign @maelk
/cc @Xenwar
/cc @fmuyassarov

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tiny comment, is it still possible to rewrite CAPM³ to CAPM3 ?

Copy link
Member

@maelk maelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe agree on the spelling of the acronym. Until now we have been using more CAPM3 I would say

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@furkatgofurov7
Copy link
Member Author

Just tiny comment, is it still possible to rewrite CAPM³ to CAPM3 ?

@fmuyassarov I was following this and this to keep consistency, in that case we have to change these as well to CAPM3? I can rewrite CAPM3 only in my patch as well.

@furkatgofurov7
Copy link
Member Author

We should maybe agree on the spelling of the acronym. Until now we have been using more CAPM3 I would say

Agree, here we have CAPM3 in other places CAPM³

@fmuyassarov
Copy link
Member

Just tiny comment, is it still possible to rewrite CAPM³ to CAPM3 ?

@fmuyassarov I was following this and this to keep consistency, in that case we have to change these as well to CAPM3? I can rewrite CAPM3 only in my patch as well.

In those docs, it is only Metal³, but not CAPM³. So, as you said for the sake of consistency maybe we could use CAPM3?

@furkatgofurov7
Copy link
Member Author

Just tiny comment, is it still possible to rewrite CAPM³ to CAPM3 ?

@fmuyassarov I was following this and this to keep consistency, in that case we have to change these as well to CAPM3? I can rewrite CAPM3 only in my patch as well.

In those docs, it is only Metal³, but not CAPM³. So, as you said for the sake of consistency maybe we could use CAPM3?

Sure, fixed

@furkatgofurov7
Copy link
Member Author

/test-v1a4-integration

Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@metal3-io-bot metal3-io-bot merged commit a827d56 into metal3-io:master Jul 20, 2020
@kashifest kashifest deleted the update-images-furkat branch June 20, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants