-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix shell parameters expansion for CAPI deployment #126
Conversation
Hi @DmitryGrayscale. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, this looks good, some comments inline.
/ok-to-test
examples/generate.sh
Outdated
# Generate Cluster API provider components file. | ||
"$KUSTOMIZE" build "github.com/kubernetes-sigs/cluster-api/config/?ref=master" > "${COMPONENTS_CLUSTER_API_GENERATED_FILE}" | ||
"$KUSTOMIZE" build "github.com/kubernetes-sigs/cluster-api/config/?ref=master" | ./envsubst-go > "${COMPONENTS_CLUSTER_API_GENERATED_FILE}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most variables in the manifests are not defined when we call envsubst. You could define a set of default variable used just to populate the example manifests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't quite understood you probably, added the following just in case
6bbfb1b#diff-2b085cd4a651deec0d4f1b1850814f02R43-R44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see that they are now with a default within the manifests, sorry, my bad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I will remove default values from the generate.sh then
9a00394
to
6bbfb1b
Compare
/test-integration |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DmitryGrayscale, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes metal3-io#125 In CAPI v0.3.7+ yaml files expressions like ${PARAM:=DEFAULTVALUE} were added. GNU envsubst can't handle such kind of expressions, so enhnaced implementation of envsubst were used to overcome this.
6bbfb1b
to
e3f8b9f
Compare
/test-integration |
What this PR does / why we need it:
In CAPI v0.3.7+ yaml files expressions like ${PARAM:=DEFAULTVALUE} were added.
GNU envsubst can't handle such kind of expressions, so enhnaced
implementation of envsubst were used to overcome this.
Which issue(s) this PR fixes:
Fixes #125