Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in comment #148

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix typo in comment #148

merged 1 commit into from
Jan 11, 2021

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com

@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2020
@metal3-io-bot
Copy link
Contributor

Hi @fenggw-fnst. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fmuyassarov
Copy link
Member

Thanks. Would you mind to fix this one too in the same PR ?

cluster-api-provider-metal3/config/crd/bases/infrastructure.cluster.x-k8s.io_metal3datatemplates.yaml

Line 828 in f43c809

description: Metal3DataTemplateSptatus defines the observed state of Metal3DataTemplate.

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2020
@fmuyassarov
Copy link
Member

Thanks. Would you mind to fix this one too in the same PR ?

cluster-api-provider-metal3/config/crd/bases/infrastructure.cluster.x-k8s.io_metal3datatemplates.yaml

Line 828 in f43c809

description: Metal3DataTemplateSptatus defines the observed state of Metal3DataTemplate.

/ok-to-test

You can run make generate-manifests to have the same fix on the manifest.

Fix typo in comment and related yaml
0e65c15 
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
@fenggw-fnst
Copy link
Contributor Author

Sure, I have updated the PR, thanks for the review.

@fmuyassarov
Copy link
Member

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@fmuyassarov
Copy link
Member

/cc @maelk

@fmuyassarov
Copy link
Member

/cc @kashifest

@maelk
Copy link
Member

maelk commented Jan 11, 2021

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fenggw-fnst, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@metal3-io-bot metal3-io-bot merged commit e3ca02b into metal3-io:master Jan 11, 2021
@fenggw-fnst fenggw-fnst deleted the work branch January 12, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelk maelk Awaiting requested review from maelk

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fenggw-fnst @metal3-io-bot @fmuyassarov @maelk