Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Install cert-manager with extension #162

Merged

Conversation

fmuyassarov
Copy link
Member

@fmuyassarov fmuyassarov commented Feb 21, 2021

What this PR does / why we need it:
Install cert-manager with extension instead of installing it ourselves. Related to kubernetes-sigs/cluster-api#3765
Link to the extension: cert-manager

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 21, 2021
@fmuyassarov
Copy link
Member Author

/test-integration
/cc @kashifest

Install cert-manager with extension
@fmuyassarov
Copy link
Member Author

/test-integration

@fmuyassarov
Copy link
Member Author

/cc @furkatgofurov7

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocker, a little nit, otherwise looks great.

tilt_modules/cert_manager/Tiltfile Show resolved Hide resolved
@furkatgofurov7
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2021
@fmuyassarov
Copy link
Member Author

/cc @maelk

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@metal3-io-bot metal3-io-bot merged commit 0208fea into metal3-io:master Mar 1, 2021
@fmuyassarov fmuyassarov deleted the cert-manager-extension/feruz branch August 14, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants