Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add Adil, Moshiur, Sunnat and Tuomo as approvers and Dmitry as a reviewer #1670

Merged
merged 1 commit into from
May 15, 2024
Merged

🌱 Add Adil, Moshiur, Sunnat and Tuomo as approvers and Dmitry as a reviewer #1670

merged 1 commit into from
May 15, 2024

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #1663

/assign tuminoid

@kashifest
Add Adil, Moshiur, Sunnat and Tuomo as approver and Dmitry as a reviewer
b13d616 
This PR adds the following people as approvers
- @adilGhaffarDev
- @smoshiur1237
- @Sunnatillo
- @tuminoid

also adds @dtantsur as a reviewer. Thanks a lot folks for your contributions.
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@metal3-io-bot metal3-io-bot mentioned this pull request May 15, 2024
Merged
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 15, 2024
@tuminoid
Copy link
Member

/retitle 🌱 Add Adil, Moshiur, Sunnat and Tuomo as approvers and Dmitry as a reviewer

@metal3-io-bot metal3-io-bot changed the title [release-1.6] 🌱 Add Adil, Moshiur, Sunnat and Tuomo as approvers and Dmitry as a reviewer 🌱 Add Adil, Moshiur, Sunnat and Tuomo as approvers and Dmitry as a reviewer May 15, 2024
@tuminoid
Copy link
Member

/override metal3-ubuntu-e2e-integration-test-release-1-6

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-release-1-6

In response to this:

/override metal3-ubuntu-e2e-integration-test-release-1-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tuminoid
tuminoid reviewed May 15, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @kashifest

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@kashifest
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@metal3-io-bot metal3-io-bot merged commit 8e4c789 into metal3-io:release-1.6 May 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@kashifest kashifest Awaiting requested review from kashifest

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@metal3-io-bot @tuminoid @kashifest