Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Allow minor version bumps for golang.org/x/* dependancies for release branch #1732

Merged

Conversation

kashifest
Copy link
Member

golang.org/x/* libs only release minor versions. No patch versions. We need to allow minor version bumps for these libs for release branches for this reason.

… branch

golang.org/x/* libs only release minor versions. No patch versions. We need to allow minor version bumps for these libs for release branches for this reason.

Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 24, 2024
@kashifest
Copy link
Member Author

/cc @tuminoid

@tuminoid
Copy link
Member

Did you find any documentation that which order the config applies, ie. should the x/net be first or last to override the * ? If you did, can you link it here for reference?

@kashifest
Copy link
Member Author

Did you find any documentation that which order the config applies, ie. should the x/net be first or last to override the * ? If you did, can you link it here for reference?

I didnt unfortunately. I am relying on the fact that the ipam ignore is working even though we have an * rule.

@tuminoid
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@metal3-io-bot metal3-io-bot merged commit 3a01fb9 into metal3-io:main May 24, 2024
15 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/allow-minor-for-golang.org/x-libs branch May 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants