-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Update golangci-lint to latest #176
Conversation
I think you need to run |
70a25ff
to
0dd707b
Compare
ff7fa37
to
0816138
Compare
0816138
to
0dd707b
Compare
0dd707b
to
bb896b7
Compare
bb896b7
to
59bad04
Compare
59bad04
to
2db3b91
Compare
/retest |
2db3b91
to
85e1a3e
Compare
85e1a3e
to
3196ca4
Compare
/test golint |
/test unit |
/test-integration |
/test-centos-integration |
068cba6
to
0f94f6e
Compare
0f94f6e
to
b456d2b
Compare
/test-integration |
2 similar comments
/test-integration |
/test-integration |
/test-centos-integration |
3 similar comments
/test-centos-integration |
/test-centos-integration |
/test-centos-integration |
/test-integration |
2 similar comments
/test-integration |
/test-integration |
b456d2b
to
2c81b19
Compare
2c81b19
to
9789d99
Compare
9789d99
to
576bdb0
Compare
@furkatgofurov7: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Tackled in #206 /close |
@furkatgofurov7: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@furkatgofurov7: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Golangci-lint is failing intermittently in a few PRs':
This patch updates it to the latest as the speed of the latest version seems to be increased a lot per
golangci/golangci-lint#685 (comment).
Since we moved to go1.16 in #161 we were hitting a go bug (see golint prow job output below, when a workaround is not applied ) for how go build works with modules - golang/go#44129This commit adds the -mod=mod flag for go build command in the Makefile (workaround mentioned in the issue).