Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update golangci-lint to latest #176

Closed
wants to merge 1 commit into from
Closed

🌱 Update golangci-lint to latest #176

wants to merge 1 commit into from

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Mar 2, 2021 •
edited
Loading

What this PR does / why we need it:
Golangci-lint is failing intermittently in a few PRs':

This patch updates it to the latest as the speed of the latest version seems to be increased a lot per
golangci/golangci-lint#685 (comment).

Since we moved to go1.16 in #161 we were hitting a go bug (see golint prow job output below, when a workaround is not applied ) for how go build works with modules - golang/go#44129

` + make lint
cd hack/tools; go build -tags=tools -o bin/golangci-lint github.com/golangci/golangci-lint/cmd/golangci-lint
go: github.com/golangci/golangci-lint@v1.37.1: missing go.sum entry; to add it:
	go mod download github.com/golangci/golangci-lint
make: *** [Makefile:124: hack/tools/bin/golangci-lint] Error 1 `

This commit adds the -mod=mod flag for go build command in the Makefile (workaround mentioned in the issue).

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2021
@furkatgofurov7 furkatgofurov7 changed the title 🌱 Update golangci-lint to latest 🌱 [WIP] Update golangci-lint to latest Mar 2, 2021
@fmuyassarov
Copy link
Member

I think you need to run go mod tidy after updating go.mod.

@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 2, 2021
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2021
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 3, 2021
@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 3, 2021
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2021
@furkatgofurov7
Copy link
Member Author

/retest

@fmuyassarov
Copy link
Member

/test golint

@fmuyassarov
Copy link
Member

/test unit

@fmuyassarov
Copy link
Member

/test-integration

@furkatgofurov7
Copy link
Member Author

/test-centos-integration

@furkatgofurov7 furkatgofurov7 changed the title 🌱 [WIP] Update golangci-lint to latest 🌱 Update golangci-lint to latest Mar 4, 2021
@furkatgofurov7 furkatgofurov7 mentioned this pull request Mar 4, 2021
Merged
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2021
@metal3-io-bot metal3-io-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2021
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 20, 2021
@fmuyassarov
Copy link
Member

/test-integration

2 similar comments
@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-integration

@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-integration

@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-centos-integration

3 similar comments
@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-centos-integration

@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-centos-integration

@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-centos-integration

@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-integration

2 similar comments
@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-integration

@maelk
Copy link
Member

maelk commented Apr 6, 2021

/test-integration

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2021
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2021
@metal3-io-bot
Copy link
Contributor

@furkatgofurov7: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
golint 576bdb0 link /test golint
generate 576bdb0 link /test generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@furkatgofurov7
Copy link
Member Author

Tackled in #206

/close

@metal3-io-bot
Copy link
Contributor

@furkatgofurov7: Closed this PR.

In response to this:

Tackled in #206

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot
Copy link
Contributor

@furkatgofurov7: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2021
@furkatgofurov7 furkatgofurov7 deleted the bump-golangci-lint/furkat branch May 7, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namnx228 namnx228 namnx228 left review comments

@fmuyassarov fmuyassarov fmuyassarov left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@furkatgofurov7 @fmuyassarov @kashifest @metal3-io-bot @maelk @namnx228