Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Set the UserAgent to "cluster-api-provider-metal3-manager" #180

Merged
merged 1 commit into from
Jul 28, 2021
Merged

🌱 Set the UserAgent to "cluster-api-provider-metal3-manager" #180

merged 1 commit into from
Jul 28, 2021

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Mar 5, 2021 •
edited
Loading

What this PR does / why we need it:
Set the UserAgent to "cluster-api-provider-metal3-manager".
This string is used to identify actors within a Kubernetes system; for instance, it appears in managedFields.

Currently, it is set to "manager" (if not set, UserAgent defaults to the name of the binary).

ref: kubernetes-sigs/cluster-api#4257.

/hold until CAPI PR is merged.

Upd: new PR has been proposed as a follow up to 4257 which is 4750 and merged in CAPI master.

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 5, 2021
@furkatgofurov7
Copy link
Member Author

/retest

@furkatgofurov7
Copy link
Member Author

/retitle 🌱 Set the UserAgent to "cluster-api-provider-metal3-controller"

@metal3-io-bot metal3-io-bot changed the title 🌱 Set the UserAgent to "capm3-controller" 🌱 Set the UserAgent to "cluster-api-provider-metal3-controller" Mar 11, 2021
@furkatgofurov7
Copy link
Member Author

/retest
/test-integration
/test-centos-integration

@furkatgofurov7
Copy link
Member Author

/test golint

fmuyassarov
fmuyassarov reviewed Mar 14, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR dependent on CAPI?

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Mar 15, 2021 •
edited
Loading

@fmuyassarov By the time when the patch was created, the discussion was still going on regarding whether or not to set UserAgent to capi-controller or cluster-api-controller, so it was on hold to make similar changes in this patch as well based on the outcome of the discussion and be consistent with capi.

@namnx228
Copy link
Member

Should we keep waiting for the PR on CAPI to go in? I guess the author will close his PR: kubernetes-sigs/cluster-api#4257 (comment)

@furkatgofurov7
Copy link
Member Author

/retest

@kashifest
Copy link
Member

Shall this PR be directed towards CAPI v1alpha4 branch now?

@fmuyassarov
Copy link
Member

/retest

@furkatgofurov7 furkatgofurov7 force-pushed the furkat/useragent branch 2 times, most recently from c713100 to 9ca6d3e Compare June 8, 2021 21:27
@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Jun 8, 2021 •
edited
Loading

/hold cancel

Should we keep waiting for the PR on CAPI to go in? I guess the author will close his PR: kubernetes-sigs/cluster-api#4257 (comment)

Please see PR description, I have updated it.

Shall this PR be directed towards CAPI v1alpha4 branch now?

Since original PR has landed in CAPI master (and other providers landing the same changes in master branch which is CAPI v1alpha4) this should be okay.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
@furkatgofurov7
Copy link
Member Author

/test-integration

@furkatgofurov7
Copy link
Member Author

/retitle seedling Set the UserAgent to "cluster-api-provider-metal3-manager"

@metal3-io-bot metal3-io-bot changed the title 🌱 Set the UserAgent to "cluster-api-provider-metal3-controller" seedling Set the UserAgent to "cluster-api-provider-metal3-manager" Jun 11, 2021
@furkatgofurov7 furkatgofurov7 changed the title seedling Set the UserAgent to "cluster-api-provider-metal3-manager" 🌱 Set the UserAgent to "cluster-api-provider-metal3-manager" Jun 11, 2021
@furkatgofurov7
Copy link
Member Author

/test-integration

@furkatgofurov7
Copy link
Member Author

/test-centos-integration

@furkatgofurov7
Copy link
Member Author

/assign @Xenwar
/cc @fmuyassarov

@Xenwar
Copy link
Member

Xenwar commented Jul 28, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@Xenwar
Copy link
Member

Xenwar commented Jul 28, 2021

/lgtm cancel

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@Xenwar
Copy link
Member

Xenwar commented Jul 28, 2021

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Xenwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2021
@fmuyassarov
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2021
@metal3-io-bot metal3-io-bot merged commit ac769c5 into metal3-io:master Jul 28, 2021
@furkatgofurov7 furkatgofurov7 deleted the furkat/useragent branch September 23, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

Assignees

@Xenwar Xenwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@furkatgofurov7 @namnx228 @kashifest @fmuyassarov @Xenwar @metal3-io-bot