Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use predefined BMH status in examples (master) #230

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Use predefined BMH status in examples (master) #230

merged 1 commit into from
Jun 24, 2021

Conversation

wgslr
Copy link
Member

@wgslr wgslr commented Jun 17, 2021

Port changes from #212 to branch master.

@wgslr
Copy link
Member Author

wgslr commented Jun 17, 2021

/test-integration

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 17, 2021
@wgslr wgslr changed the title Update/examples wgslr Use predefined BMH status in examples (master) Jun 17, 2021
fmuyassarov
fmuyassarov approved these changes Jun 21, 2021
View reviewed changes
docs/dev-setup.md Outdated Show resolved Hide resolved
@wgslr
Copy link
Member Author

wgslr commented Jun 22, 2021

/test-integration

@wgslr
Copy link
Member Author

wgslr commented Jun 22, 2021

/test markdownlint

furkatgofurov7
furkatgofurov7 reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2021
@wgslr
Copy link
Member Author

wgslr commented Jun 22, 2021

/test markdownlin

@metal3-io-bot
Copy link
Contributor

@wgslr: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test gofmt
  • /test golint
  • /test govet
  • /test markdownlint
  • /test shellcheck
  • /test generate
  • /test unit
  • /test manifestlint

Use /test all to run all jobs.

In response to this:

/test markdownlin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wgslr
Copy link
Member Author

wgslr commented Jun 22, 2021

/test markdownlint

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2021
@wgslr
Copy link
Member Author

wgslr commented Jun 24, 2021

/test-integration

@fmuyassarov
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@metal3-io-bot metal3-io-bot merged commit 87a68f3 into metal3-io:master Jun 24, 2021
@kashifest kashifest deleted the update/examples-wgslr branch June 20, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wgslr @metal3-io-bot @fmuyassarov @furkatgofurov7