-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖update architecture doc per current output #270
Conversation
Hi @jichenjc. Thanks for your PR. I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks for the PR @jichenjc! Please fix the markdown issue, and we can trigger mandatory integration test. Thank you. |
@furkatgofurov7 thanks~, updated |
/test-integration |
@jichenjc I just noticed there are few more places in the same documentation where it needs an update in terms of API versions(all CAPI objects should have |
@furkatgofurov7 updated again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there is only one mention of API for Metal3Cluster that is left still in line 131 that needs an update.
ok, updated~, thanks |
/test-integration |
|image: | | ||
| checksum: http://172.22.0.1/images/bionic-server-cloudimg-amd64.img.md5sum| | ||
| url: http://172.22.0.1/images/bionic-server-cloudimg-amd64.img | | ||
|online: true | | ||
|# UserData comes from 'Metal3Machine' and is added by 'CAPBK' | | ||
|# UserData comes from 'Metal3Machine' and is added by 'CAPBK' | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still called CAPBK?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmuyassarov, kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
some of the existing doc output is incorrect per test result
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #