Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖update architecture doc per current output #270

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

jichenjc
Copy link
Contributor

What this PR does / why we need it:

some of the existing doc output is incorrect per test result

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot
Copy link
Contributor

Hi @jichenjc. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2021
@furkatgofurov7
Copy link
Member

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2021
@furkatgofurov7
Copy link
Member

Thanks for the PR @jichenjc! Please fix the markdown issue, and we can trigger mandatory integration test. Thank you.

@jichenjc
Copy link
Contributor Author

@furkatgofurov7 thanks~, updated

@furkatgofurov7
Copy link
Member

/test-integration

@furkatgofurov7
Copy link
Member

@jichenjc I just noticed there are few more places in the same documentation where it needs an update in terms of API versions(all CAPI objects should have v1alpha4 and CAPM3 objects v1alpha5 API versions). It would be great, if you could take care of updating those in the same PR.

@jichenjc
Copy link
Contributor Author

@furkatgofurov7 updated again :)

Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there is only one mention of API for Metal3Cluster that is left still in line 131 that needs an update.

@jichenjc
Copy link
Contributor Author

ok, updated~, thanks

@furkatgofurov7
Copy link
Member

/test-integration
/lgtm
/cc @kashifest

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
|image: |
| checksum: http://172.22.0.1/images/bionic-server-cloudimg-amd64.img.md5sum|
| url: http://172.22.0.1/images/bionic-server-cloudimg-amd64.img |
|online: true |
|# UserData comes from 'Metal3Machine' and is added by 'CAPBK' |
|# UserData comes from 'Metal3Machine' and is added by 'CAPBK' |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still called CAPBK?

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@metal3-io-bot metal3-io-bot merged commit 0319fc4 into metal3-io:master Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants