Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Extend releasing document #274

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

fmuyassarov
Copy link
Member

What this PR does / why we need it:
Add a step explaining how to create BMO & Ironic container images with a specific tag whenever making a new release of CAPM3.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2021
@fmuyassarov
Copy link
Member Author

/cc @maelk

@fmuyassarov fmuyassarov force-pushed the release-doc-update/feruz branch 2 times, most recently from d2ea489 to ca565d6 Compare August 21, 2021 13:50
docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
docs/releasing.md Outdated Show resolved Hide resolved
@@ -86,3 +87,26 @@ CAPM3 and the released version should point to the release branch.
If you just created a release branch (i.e. minor version release), you should
modify the image for CAPM3 deployment in this branch to be tagged with the
branch name. The image will then follow the branch.

### Create a new tag for Ironic and BMO images
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself. What is the motivation behind to add a prefix to these container images? is there a specific case or reason etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For every release of CAPM3 we are specifying the current version of Ironic and BMO images which work with the current CAPM3 code. Since at the time there is no images with the future tag, we are creating them at the same time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see capm3-v0.4.3 baremetal-operator container image in quay, and that is for CAPM3 v0.4.3 release as I got to know. That means we have to adapt m3-dev-env too to use those images accordingly?

Copy link
Member Author

@fmuyassarov fmuyassarov Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, if not already

@fmuyassarov
Copy link
Member Author

/test-integration

Copy link
Member

@namnx228 namnx228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov
Copy link
Member Author

/cc @kashifest @namnx228

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, namnx228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021
@metal3-io-bot metal3-io-bot merged commit c090121 into metal3-io:master Aug 24, 2021
@fmuyassarov fmuyassarov deleted the release-doc-update/feruz branch November 16, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants