-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Extend releasing document #274
📖 Extend releasing document #274
Conversation
/cc @maelk |
d2ea489
to
ca565d6
Compare
@@ -86,3 +87,26 @@ CAPM3 and the released version should point to the release branch. | |||
If you just created a release branch (i.e. minor version release), you should | |||
modify the image for CAPM3 deployment in this branch to be tagged with the | |||
branch name. The image will then follow the branch. | |||
|
|||
### Create a new tag for Ironic and BMO images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself. What is the motivation behind to add a prefix to these container images? is there a specific case or reason etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For every release of CAPM3 we are specifying the current version of Ironic and BMO images which work with the current CAPM3 code. Since at the time there is no images with the future tag, we are creating them at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see capm3-v0.4.3
baremetal-operator container image in quay, and that is for CAPM3 v0.4.3 release as I got to know. That means we have to adapt m3-dev-env too to use those images accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably yes, if not already
ca565d6
to
0be0285
Compare
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @kashifest @namnx228 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest, namnx228 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What this PR does / why we need it:
Add a step explaining how to create BMO & Ironic container images with a specific tag whenever making a new release of CAPM3.