🐛 Fix the deletion step order and OwnerReference matching, add matchpolicy to webhooks #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to delete the userData secret before releasing the host to prevent an NPE. Also updates to CAPI v0.3.2
to not check the version, in order to keep everything working across version upgrades.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
|
/cc @kashifest |
|
/test-integration |
|
/test-v1a4-integration |
|
/test-v1a4-integration |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the order of the deletion steps for Metal3Machine to prevent a NPE (#22)
It also changes the way the OwnerReferences are matched to not take into account the version, that
might change after an upgrade.
It also upgrades controller-gen for CAPI v0.3.2
It adds matchPolicy=Equivalent to the webhook to match across versions
Which issue(s) this PR fixes:
Fixes #22
Fixes #30