Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Parameterize API versions in e2e templates #286

Merged
merged 1 commit into from
Sep 8, 2021
Merged

🌱 Parameterize API versions in e2e templates #286

merged 1 commit into from
Sep 8, 2021

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Sep 6, 2021 •
edited
Loading

No description provided.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2021
@furkatgofurov7
Copy link
Member Author

/test-v1a5-e2e

@furkatgofurov7
Copy link
Member Author

/test-v1a5-e2e

@furkatgofurov7
Copy link
Member Author

/test-v1a5-centos-e2e
/test-integration

namnx228
namnx228 approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@namnx228 namnx228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot
Copy link
Contributor

@namnx228: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2021
@furkatgofurov7
Copy link
Member Author

/test-v1a5-e2e
/test-v1a5-centos-e2e
/test-integration

@smoshiur1237
Copy link
Member

Looks good to me

@furkatgofurov7
Copy link
Member Author

/test-v1a5-centos-e2e

@furkatgofurov7
Copy link
Member Author

/assign @kashifest
/cc @jan-est @Xenwar @fmuyassarov

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, namnx228

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2021
fmuyassarov
fmuyassarov reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@metal3-io-bot metal3-io-bot merged commit 55545d6 into metal3-io:master Sep 8, 2021
@furkatgofurov7 furkatgofurov7 deleted the param-api-version-e2e branch September 23, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@namnx228 namnx228 namnx228 approved these changes

@kashifest kashifest kashifest approved these changes

@jan-est jan-est Awaiting requested review from jan-est

@Xenwar Xenwar Awaiting requested review from Xenwar

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@furkatgofurov7 @metal3-io-bot @smoshiur1237 @namnx228 @fmuyassarov @kashifest