Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Uplift sigs.k8s.io/cluster-api/test to v1.0.1 #387

Merged
merged 1 commit into from Nov 18, 2021
Merged

🌱 Uplift sigs.k8s.io/cluster-api/test to v1.0.1 #387

merged 1 commit into from Nov 18, 2021

Conversation

kashifest
Copy link
Member

@kashifest kashifest commented Nov 16, 2021 •
edited

Couldn't uplift capi/test to v1.0.1 in #381 since CAPI folks missed test/v1.0.1 tag in the release somehow and now they have added it.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2021
@kashifest
Copy link
Member Author

/test-v1b1-integration

@metal3-io-bot metal3-io-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2021
@kashifest
Copy link
Member Author

/test-v1b1-integration

@kashifest
Copy link
Member Author

/test-v1b1-e2e

fmuyassarov
fmuyassarov reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@kashifest
Copy link
Member Author

/test-v1b1-e2e

1 similar comment
@kashifest
Copy link
Member Author

/test-v1b1-e2e

furkatgofurov7
furkatgofurov7 approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2021
@metal3-io-bot metal3-io-bot merged commit 8ca3455 into metal3-io:main Nov 18, 2021
@fmuyassarov fmuyassarov changed the title ✨ Uplift sigs.k8s.io/cluster-api/test to v1.0.1 🌱 Uplift sigs.k8s.io/cluster-api/test to v1.0.1 Feb 21, 2022
@kashifest kashifest deleted the uplift/capi-test-1.0.1 branch June 20, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmuyassarov fmuyassarov fmuyassarov left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kashifest @metal3-io-bot @fmuyassarov @furkatgofurov7