Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Add v1alpha4 API and conversion webhook changes #5

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

maelk
Copy link
Member

@maelk maelk commented Mar 9, 2020

What this PR does / why we need it:
This PR adds the v1alpha4 API for CAPM3 and does according changes in the controller and webhooks

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 9, 2020
@maelk
Copy link
Member Author

maelk commented Mar 9, 2020

/test-integration

1 similar comment
@maelk
Copy link
Member Author

maelk commented Mar 9, 2020

/test-integration

to prevent a condition when we are not triggered after a machine
update
@maelk
Copy link
Member Author

maelk commented Mar 9, 2020

/test-integration

@maelk
Copy link
Member Author

maelk commented Mar 10, 2020

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
@maelk
Copy link
Member Author

maelk commented Mar 10, 2020

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
Copy link
Member

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@Xenwar
Copy link
Member

Xenwar commented Mar 10, 2020

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@metal3-io-bot metal3-io-bot merged commit ad1778a into metal3-io:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants