Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 UpdateObject function should operate on a deepcopy of the object #50

Merged
merged 1 commit into from Mar 27, 2020
Merged

🐛 UpdateObject function should operate on a deepcopy of the object #50

merged 1 commit into from Mar 27, 2020

Conversation

Jaakko-Os
Copy link
Member

Fixes: #46

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2020
@Jaakko-Os
Copy link
Member Author

/test-v1a4-integration

maelk
maelk suggested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@maelk maelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deepCopy should not be on the object given to the function, but inside the function

@maelk
Copy link
Member

maelk commented Mar 26, 2020

It should be here https://github.com/metal3-io/cluster-api-provider-metal3/blob/master/baremetal/metal3machine_manager.go#L1071 and here https://github.com/metal3-io/cluster-api-provider-metal3/blob/master/baremetal/metal3machine_manager.go#L1079

@Jaakko-Os
Copy link
Member Author

/test-v1a4-integration

@Jaakko-Os Jaakko-Os requested a review from maelk March 27, 2020 06:22
@maelk
Copy link
Member

maelk commented Mar 27, 2020

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jaakko-Os, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2020
@kashifest
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020
@metal3-io-bot metal3-io-bot merged commit 489d91e into metal3-io:master Mar 27, 2020
@Jaakko-Os Jaakko-Os deleted the bug-46-jaakko branch March 27, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maelk maelk maelk requested changes

Assignees

@kashifest kashifest

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UpdateObject function should operate on a deepcopy of the object
4 participants
@Jaakko-Os @maelk @metal3-io-bot @kashifest