✨ PR prevents the use of BMH annotated as unhealthy #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/S
kashifest
reviewed
Jun 9, 2020
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
6776a33
to
eb933b8
Compare
metal3-io-bot
added
size/XS
|
/test golint |
|
/test govet |
|
/retest |
|
this should have a go.mod update to use the new version of BMO with the annotation definition |
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
eb933b8
to
55d0e43
Compare
metal3-io-bot
added
size/S
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
2 times, most recently
from
ff34b90
to
6366e1c
Compare
|
/test-v1a4-integration |
|
/hold |
metal3-io-bot
added
the
do-not-merge/hold
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
6366e1c
to
681df2b
Compare
|
/test-v1a4-integration |
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
681df2b
to
5731020
Compare
|
/test-v1a4-integration |
|
/unhold |
metal3-io-bot
removed
the
do-not-merge/hold
|
/test-v1a4-integration |
maelk
reviewed
Jun 11, 2020
|
/assign @hardys |
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
5731020
to
d2d6c7b
Compare
|
/test-v1a4-integration |
1 similar comment
|
/test-v1a4-integration |
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
2 times, most recently
from
52ce72d
to
840ff8d
Compare
metal3-io-bot
added
size/M
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
840ff8d
to
7446373
Compare
metal3-io-bot
added
size/XXL
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
7446373
to
f3219ef
Compare
metal3-io-bot
added
size/M
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
f3219ef
to
51b17d5
Compare
metal3-io-bot
added
size/S
|
/test-v1a4-integration |
maelk
reviewed
Jun 15, 2020
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
51b17d5
to
f087872
Compare
|
/test gofmt |
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
f087872
to
46c13ab
Compare
|
/test-v1a4-integration |
maelk
approved these changes
Jun 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan-est, maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
kashifest
reviewed
Jun 16, 2020
jan-est
force-pushed
the
unhealthy-node-handling-jan
branch
from
46c13ab
to
f0d27bd
Compare
|
/test-v1a4-integration |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
UnhealthyAnnotation = "capi.metal3.io/unhealthy"and PR prevents the unhealthy BMH from being selected as the host for metal3machine. With new annotation users can mark BMH as unhealthy.