🏃 Update test scripts #99
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
|
/test-integration |
|
/cc @kashifest |
| if [ "${IS_CONTAINER}" != "false" ]; then | ||
| export XDG_CACHE_HOME=/tmp/.cache | ||
| eval "$(go env)" | ||
| cd "${GOPATH}"/src/github.com/metal3-io/cluster-api-provider-metal3 |
There was a problem hiding this comment.
Don't you need to export GOPATH?
There was a problem hiding this comment.
it's defined as part of line 11
| config/manager/*.yaml | ||
| config/rbac/*.yaml | ||
| config/webhook/*.yaml | ||
| config/*.yaml |
There was a problem hiding this comment.
I don't see /bmo. I'm not sure if it also needs to be added or not?
There was a problem hiding this comment.
this is v1a3, there is no BMO, and no ipam
hack/codegen.sh
Outdated
| IS_CONTAINER=${IS_CONTAINER:-false} | ||
| ARTIFACTS=${ARTIFACTS:-/tmp} |
There was a problem hiding this comment.
Double quotes around curly brackets?
There was a problem hiding this comment.
Do we need double quotes here? Check this
hack/golint.sh
Outdated
|
|
||
| set -eux | ||
|
|
||
| IS_CONTAINER=${IS_CONTAINER:-false} |
There was a problem hiding this comment.
Double quotes around curly brackets?
|
/test-integration |
Adds golint.sh and codegen.sh and make gofmt.sh fail if files are changed
|
/test-integration |
What this PR does / why we need it:
Adds golint.sh and codegen.sh and make gofmt.sh fail if files
are changed