Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

Start using Centos 8 as base #37

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

elfosardo
Copy link
Member

Start testing images with Centos 8 as base.

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 7, 2019
@elfosardo elfosardo changed the title [WIP] start using Centos 8 as base Start using Centos 8 as base Jan 3, 2020
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2020
@elfosardo elfosardo force-pushed the use-centos8 branch 2 times, most recently from d0834a2 to 7ade1e8 Compare January 6, 2020 13:15
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2020
@elfosardo
Copy link
Member Author

/cc @dtantsur
/cc @juliakreger
/cc @hardys

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
dnf update -y && \
dnf install -y openstack-ironic-inspector crudini psmisc iproute sqlite && \
dnf clean all && \
rm -rf /var/cache/{yum,dnf}/*

RUN mkdir -p /var/lib/ironic-inspector && \
sqlite3 /var/lib/ironic-inspector/ironic-inspector.db "pragma journal_mode=wal"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the sqlite package after this command

Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2020
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot merged commit bba0ec1 into metal3-io:master Jan 16, 2020
elfosardo pushed a commit to elfosardo/ironic-inspector-image that referenced this pull request Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants