This repository has been archived by the owner on Sep 29, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Oct 7, 2019
elfosardo
changed the title
[WIP] start using Centos 8 as base
Start using Centos 8 as base
Jan 3, 2020
metal3-io-bot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jan 3, 2020
elfosardo
force-pushed
the
use-centos8
branch
2 times, most recently
from
January 6, 2020 13:15
d0834a2
to
7ade1e8
Compare
metal3-io-bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jan 6, 2020
/cc @dtantsur |
dtantsur
approved these changes
Jan 10, 2020
metal3-io-bot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 10, 2020
dtantsur
reviewed
Jan 16, 2020
dnf update -y && \ | ||
dnf install -y openstack-ironic-inspector crudini psmisc iproute sqlite && \ | ||
dnf clean all && \ | ||
rm -rf /var/cache/{yum,dnf}/* | ||
|
||
RUN mkdir -p /var/lib/ironic-inspector && \ | ||
sqlite3 /var/lib/ironic-inspector/ironic-inspector.db "pragma journal_mode=wal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the sqlite
package after this command
dtantsur
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur, elfosardo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Mar 3, 2020
elfosardo
pushed a commit
to elfosardo/ironic-inspector-image
that referenced
this pull request
Jul 24, 2020
Backport - Add http_basic auth support
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start testing images with Centos 8 as base.