Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for local image building #104

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Support for local image building #104

merged 1 commit into from
Oct 24, 2019

Conversation

stbenjam
Copy link
Member

This ports the local image building code form OpenShift dev-scripts to
metal3-dev-env. It starts a local registry, and if a user has specified
_LOCAL_IMAGE variables, will build and push those images to the
registry.

kustomize is used to override the images in baremetal-operator.

Example:

export IRONIC_LOCAL_IMAGE=file:///home/notstack/ironic-image
make

stbenjam
stbenjam commented Oct 22, 2019
View reviewed changes
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
@hardys hardys mentioned this pull request Oct 22, 2019
Merged
9 tasks
@stbenjam
Copy link
Member Author

/test-integration

@stbenjam
Copy link
Member Author

/test-centos-integration

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2019
@stbenjam
Copy link
Member Author

/test-integration

@stbenjam
Copy link
Member Author

/test-centos-integration

@hardys hardys requested a review from maelk October 23, 2019 08:49
@hardys
Copy link
Member

hardys commented Oct 23, 2019

This looks good to me, we've found these interfaces to be very convenient for local image testing in dev-scripts so it will be good to add them here, I guess it may simplify CI testing as well when we have cross-repo dependencies in future.

Other than needing the BMO PR to land first this lgtm, added @maelk for review too

@stbenjam stbenjam mentioned this pull request Oct 23, 2019
Merged
@stbenjam stbenjam force-pushed the local-images branch 2 times, most recently from 43f1189 to 7d083bc Compare October 23, 2019 19:58
@stbenjam
Copy link
Member Author

/test-centos-integration

@stbenjam
Copy link
Member Author

/test-integration

maelk
maelk reviewed Oct 24, 2019
View reviewed changes
Copy link
Member

@maelk maelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside of the podman reference, this looks good to me

02_configure_host.sh Outdated Show resolved Hide resolved
02_configure_host.sh Outdated Show resolved Hide resolved
@stbenjam
Support for local image building
09ba7ec 
This ports the local image building code form OpenShift dev-scripts to
metal3-dev-env. It starts a local registry, and if a user has specified
_LOCAL_IMAGE variables, will build and push those images to the
registry.

`kustomize` is used to override the images in baremetal-operator.

Example:

```
export IRONIC_LOCAL_IMAGE=file:///home/notstack/ironic-image
make
```
@maelk
Copy link
Member

maelk commented Oct 24, 2019

/test-integration

@maelk
Copy link
Member

maelk commented Oct 24, 2019

/test-centos-integration

@maelk
Copy link
Member

maelk commented Oct 24, 2019

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@metal3-io-bot metal3-io-bot merged commit c4e7365 into metal3-io:master Oct 24, 2019
@stbenjam stbenjam deleted the local-images branch October 24, 2019 11:21
@maelk maelk mentioned this pull request Oct 25, 2019
Merged
@stbenjam stbenjam mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys hardys left review comments

@maelk maelk maelk left review comments

Assignees

@maelk maelk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stbenjam @metal3-io-bot @hardys @maelk