Freeze the version of kubelet, kubectl and kubeadm #273

Xenwar · 2020-03-26T12:00:32Z

As we have it now, KUBERNETES_VERSION is fixed in time. However, the binaries (kubelet, kubeadm and kubectl), are always the latest and this causes a mismatch between the two.

The purpose of this PR is then making both freeze in time and prevent auto update/upgrade of both. This allows developers to keep using specific version, if they wish to do so.

In future works, we intend to use the metal3-dev-env for testing upgrade workflow, where the kuberenetes and binaries upgrade is done independently. To that end, we have added a new variable. KUBERNETES_BINARIES_VERSION which defaults to the value of KUBERNETES_VERSION

This PR makes the versions both of KUBERNETES_VERSION and KUBERNETES_BINARIES_VERSION set to 1.17.0 only for testing purpose.

Fixes #271

fmuyassarov · 2020-03-26T12:34:31Z

lib/common.sh

@@ -111,6 +111,7 @@ export DEFAULT_HOSTS_MEMORY=${DEFAULT_HOSTS_MEMORY:-8192}
 export CLUSTER_NAME=${CLUSTER_NAME:-"test1"}
 export CLUSTER_APIENDPOINT_IP=${CLUSTER_APIENDPOINT_IP:-"192.168.111.249"}
 export KUBERNETES_VERSION=${KUBERNETES_VERSION:-"v1.18.0"}
+export K3_BINARIES_VERSION=${K3_BINARIES_VERSION:-"1.18.0"}


why not to use KUBERNETES_VERSION variable ?

They are not in the same format. (v)
:-"v1.18.0"
:-"1.18.0"

I see, but then you should change also K3_BINARIES_VERSION to be default('1.18.0', true) }}" in vm-setup/roles/v1aX_integration_test/vars/main.yml , no?

I think I have done so.
It is included in this commit

you could make KUBERNETES_VERSION to be 1.18.0 and then wherever used add the v in front, that would be better than creating this duplicated variable

ok. I will look into that.

fmuyassarov · 2020-03-26T13:00:30Z

/test-integration

fmuyassarov · 2020-03-26T14:45:31Z

/test-integration

Xenwar · 2020-03-27T05:30:26Z

/test-integration

maelk · 2020-03-27T06:38:11Z

why K3 btw ?

maelk · 2020-03-27T06:40:14Z

now you are missing the setting of the variable in the lib/common.sh. Kubernetes version is set there, we should have both at the same place. Also, if you add something into lib/common.sh, it should be considered whether that should be added in config_example.sh or not and on the try-it.md of the website

Xenwar

why K3 btw ?

It stands for the three binaries. kubeadm, kubectl and kubelet.
Also tried 3K, but it did not accept it.
And, I thought it would be too long to write KUBEADM_KUBELET_KUBECTL_VERSION

Xenwar · 2020-03-26T12:48:26Z

lib/common.sh

@@ -111,6 +111,7 @@ export DEFAULT_HOSTS_MEMORY=${DEFAULT_HOSTS_MEMORY:-8192}
 export CLUSTER_NAME=${CLUSTER_NAME:-"test1"}
 export CLUSTER_APIENDPOINT_IP=${CLUSTER_APIENDPOINT_IP:-"192.168.111.249"}
 export KUBERNETES_VERSION=${KUBERNETES_VERSION:-"v1.18.0"}
+export K3_BINARIES_VERSION=${K3_BINARIES_VERSION:-"1.18.0"}


I think I have done so.
It is included in this commit

Xenwar · 2020-03-27T04:27:55Z

lib/common.sh

@@ -111,6 +111,7 @@ export DEFAULT_HOSTS_MEMORY=${DEFAULT_HOSTS_MEMORY:-8192}
 export CLUSTER_NAME=${CLUSTER_NAME:-"test1"}
 export CLUSTER_APIENDPOINT_IP=${CLUSTER_APIENDPOINT_IP:-"192.168.111.249"}
 export KUBERNETES_VERSION=${KUBERNETES_VERSION:-"v1.18.0"}
+export K3_BINARIES_VERSION=${K3_BINARIES_VERSION:-"1.18.0"}


ok. I will look into that.

Xenwar · 2020-03-27T07:12:44Z

@maelk
Added the value in
lib/common.sh
config_example.sh (this may not be needed as the Kubernetes version is not there either)
try-it.html

maelk

lgtm, just a nit, it could still be KUBERNETES_BINARIES_VERSION, and could default to KUBERNETES_BINARIES_VERSION="${KUBERNETES_BINARIES_VERSION:-${KUBERNETES_VERSION#'v'}}" that will just remove the v from the K8S version

maelk · 2020-03-27T07:17:35Z

I think it is obvious that kubernetes binaries cover kubeadm kubectl and kubelet

vm-setup/roles/v1aX_integration_test/vars/main.yml

Xenwar · 2020-03-27T07:35:51Z

I think it is obvious that kubernetes binaries cover kubeadm kubectl and kubelet

I agree. We can remove it. It is needed for upgrading automated tests. Even in that it is only test case.

kashifest · 2020-03-27T08:28:48Z

/lgtm

kashifest · 2020-03-27T08:29:14Z

/tesct-centos-integration

Xenwar · 2020-03-27T08:49:37Z

lgtm, just a nit, it could still be KUBERNETES_BINARIES_VERSION, and could default to KUBERNETES_BINARIES_VERSION="${KUBERNETES_BINARIES_VERSION:-${KUBERNETES_VERSION#'v'}}" that will just remove the v from the K8S version

Changed accordingly.

Xenwar · 2020-04-01T08:54:32Z

/test-integration

Xenwar · 2020-04-01T09:03:21Z

/test-centos-integration

Xenwar · 2020-04-01T09:08:06Z

/test-integration

maelk

ok for me, but I think we should rather go with K8S 1.18.0 now that the tests are passing

Xenwar · 2020-04-01T10:41:12Z

ok for me, but I think we should rather go with K8S 1.18.0 now that the tests are passing

Thanks.
I agree. Forgot changing it as described in the description.

Xenwar · 2020-04-01T10:42:37Z

/test-integration

Xenwar · 2020-04-01T10:42:51Z

/test-centos-integration

Xenwar · 2020-04-01T10:44:53Z

please do wait for test result with 1.18.0 (current code) before giving lgtm or approval

Xenwar · 2020-04-01T11:35:29Z

/test-centos-integration

Xenwar · 2020-04-01T13:53:00Z

/test-centos-integration

Xenwar · 2020-04-01T13:53:12Z

/test-integration

Xenwar · 2020-04-02T06:22:18Z

The test with v1.18.0 is failing due to missing files, unlike previous releases.
An issue is created in kuberentes, kubernetes/kubernetes#89757.

I suggest we hold this until the issue is resolved.

Fixes metal3-io#271 Signed-off-by: Anwar Hassen <anwar.hassen@est.tech>

Xenwar · 2020-04-02T08:49:00Z

/test-centos-integration

Xenwar · 2020-04-02T08:49:13Z

/test-integration

fmuyassarov

/lgtm

metal3-io-bot · 2020-04-02T10:26:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelk, Xenwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [maelk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Xenwar changed the title ~~Freeze the version of kubelet, kubectl and kubeadm~~ [WIP]: Freeze the version of kubelet, kubectl and kubeadm Mar 26, 2020

metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2020

fmuyassarov reviewed Mar 26, 2020

View reviewed changes

Xenwar force-pushed the freeze_kube-binaries branch from d931ccf to 6482d81 Compare March 26, 2020 12:55

Xenwar force-pushed the freeze_kube-binaries branch 2 times, most recently from 3730c11 to d3b9281 Compare March 27, 2020 05:29

Xenwar changed the title ~~[WIP]: Freeze the version of kubelet, kubectl and kubeadm~~ Freeze the version of kubelet, kubectl and kubeadm Mar 27, 2020

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2020

Xenwar commented Mar 27, 2020

View reviewed changes

Xenwar force-pushed the freeze_kube-binaries branch from d3b9281 to f66a90a Compare March 27, 2020 07:09

Xenwar mentioned this pull request Mar 27, 2020

Added K3_BINARIES_VERSION variable for version of kubeadm, kubectl and kubeadm metal3-io/metal3-io.github.io#174

Closed

maelk reviewed Mar 27, 2020

View reviewed changes

kashifest reviewed Mar 27, 2020

View reviewed changes

vm-setup/roles/v1aX_integration_test/vars/main.yml Show resolved Hide resolved

Xenwar force-pushed the freeze_kube-binaries branch from f66a90a to e7c91b7 Compare March 27, 2020 08:26

metal3-io-bot assigned kashifest Mar 27, 2020

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020

Xenwar force-pushed the freeze_kube-binaries branch from e7c91b7 to 12a8cf3 Compare March 27, 2020 08:47

metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2020

Xenwar force-pushed the freeze_kube-binaries branch from c58548d to aa8da1f Compare April 1, 2020 08:54

maelk reviewed Apr 1, 2020

View reviewed changes

Xenwar force-pushed the freeze_kube-binaries branch from aa8da1f to cfacbf5 Compare April 1, 2020 10:40

Xenwar changed the title ~~[WIP]Freeze the version of kubelet, kubectl and kubeadm~~ Freeze the version of kubelet, kubectl and kubeadm Apr 1, 2020

metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2020

Jaakko-Os mentioned this pull request Apr 2, 2020

[WIP] Upgrade workflow documentation Nordix/metal3-docs#2

Closed

Freeze the version of kubelet, kubectl and kubeadm

8135727

Fixes metal3-io#271 Signed-off-by: Anwar Hassen <anwar.hassen@est.tech>

Xenwar force-pushed the freeze_kube-binaries branch from cfacbf5 to 8135727 Compare April 2, 2020 08:48

fmuyassarov reviewed Apr 2, 2020

View reviewed changes

metal3-io-bot assigned fmuyassarov Apr 2, 2020

metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2020

maelk approved these changes Apr 2, 2020

View reviewed changes

metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020

metal3-io-bot merged commit 8b7bedb into metal3-io:master Apr 2, 2020

maelk mentioned this pull request Apr 7, 2020

CentOS target cluster deployment fails #287

Closed

Xenwar deleted the freeze_kube-binaries branch October 22, 2020 11:09

Freeze the version of kubelet, kubectl and kubeadm #273

Freeze the version of kubelet, kubectl and kubeadm #273

Conversation

Xenwar commented Mar 26, 2020 • edited Loading

fmuyassarov Mar 26, 2020

Choose a reason for hiding this comment

Xenwar Mar 26, 2020

Choose a reason for hiding this comment

fmuyassarov Mar 26, 2020 • edited Loading

Choose a reason for hiding this comment

Xenwar Mar 26, 2020

Choose a reason for hiding this comment

maelk Mar 26, 2020

Choose a reason for hiding this comment

Xenwar Mar 27, 2020

Choose a reason for hiding this comment

fmuyassarov commented Mar 26, 2020

fmuyassarov commented Mar 26, 2020

Xenwar commented Mar 27, 2020

maelk commented Mar 27, 2020

maelk commented Mar 27, 2020

Xenwar left a comment

Choose a reason for hiding this comment

Xenwar Mar 26, 2020

Choose a reason for hiding this comment

Xenwar Mar 27, 2020

Choose a reason for hiding this comment

Xenwar commented Mar 27, 2020

maelk left a comment

Choose a reason for hiding this comment

maelk commented Mar 27, 2020

Xenwar commented Mar 27, 2020

kashifest commented Mar 27, 2020

kashifest commented Mar 27, 2020

Xenwar commented Mar 27, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

maelk left a comment

Choose a reason for hiding this comment

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 1, 2020

Xenwar commented Apr 2, 2020

Xenwar commented Apr 2, 2020

Xenwar commented Apr 2, 2020

fmuyassarov left a comment

Choose a reason for hiding this comment

metal3-io-bot commented Apr 2, 2020

Xenwar commented Mar 26, 2020 •

edited

Loading

fmuyassarov Mar 26, 2020 •

edited

Loading