-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to DIY callback plugin for Ansible #711
Switch to DIY callback plugin for Ansible #711
Conversation
Skipping CI for Draft Pull Request. |
/test-integration |
7245be7
to
1793472
Compare
/test-integration |
1793472
to
4055798
Compare
/test-integration |
4055798
to
5d94d63
Compare
/test-integration |
5d94d63
to
b2afd93
Compare
/test-integration |
b2afd93
to
cd23e08
Compare
/test-integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like that we less output instead of having too much stdout which we don't really read and it just takes extra space and makes it complicated to read the logs.
I'm +1 for this.
cd23e08
to
503c29e
Compare
/test-integration |
503c29e
to
0c87b5c
Compare
/test-integration |
0c87b5c
to
6a40c53
Compare
/test-integration |
/test-v1a4-centos-integration |
Significant improvements with less logs and will be easy to read the logs. Good work. |
The DIY callback plugin is configured to print only the status of k8s resources instead of everything (but otherwise work as before). Ansible verbosity is turned down to default.
6a40c53
to
cc03f55
Compare
/test-integration Alright, I think it is ready to go now. Removed the example part. Please review/approve if you like it 🙂 |
/assign @kashifest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
The DIY callback plugin is configured to print only the status of k8s resources instead of everything (but otherwise work as before). Ansible verbosity is also turned down to default.
The goal is to reduce the amount of useless logs produced by the CI but still show relevant/interesting parts.
My reasoning is as follows. Note that all of this is very much open for discussion. This is just my point of view.
-vvv
. If a task fails, it will usually anyway print extra information about the error, so we skip-vvv
and should still get the most important information.k8s_info
module that we are now using a bit more prints everything (including all the managed fields and what not) when running with-vvv
. This is too much. Without-vvv
it doesn't print anything though, and that is too little. It becomes hard to tell what is going on for example when a task is usinguntil
to wait for some node/machine/bmh.Solution: use the DIY callback and configure it to print only the
status
field of all resources (+ name and kind). This gives us the most valuable information while still reducing the amount of logs quite a lot. (Note that we will still get the full output if a task fails.)