Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in label_sync from openshift #12

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Oct 3, 2019

Can we use this same code from openshift's test-infra (which was forked from k8s') to setup our labels? This would ensure we have consistent colors. We'll need to run the script against the metal3-io org to sync everything. The grey labels are kind of boring to look at :-)

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2019
@stbenjam
Copy link
Member Author

stbenjam commented Oct 3, 2019

/assign russellb

@russellb
Copy link
Member

russellb commented Oct 7, 2019

I'm happy to use this. It looks like a config file is needed before we can turn this on. Would you like to propose some config? If so, do you want to add it to this PR? or want to merge this and follow up?

@stbenjam
Copy link
Member Author

stbenjam commented Oct 7, 2019

Yea, it has the option for a cron job yaml, but it looks like OpenShift just runs it by hand (or their config is stored elsewhere) since their fork just has the default k8s config.

Something like this would create the labels on all the repos in our org according to the README.

bazel run //label_sync -- \
  --config $(pwd)/label_sync/labels.yaml \
  --token /path/to/github_oauth_token \
  --orgs metal3-io

@russellb
Copy link
Member

russellb commented Oct 8, 2019

/approve
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: russellb, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2019
@metal3-io-bot metal3-io-bot merged commit 625a904 into metal3-io:master Oct 8, 2019
@stbenjam stbenjam deleted the labels branch October 8, 2019 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants