Skip to content

Commit

Permalink
speakerlist: Add TODO about ml event channel
Browse files Browse the repository at this point in the history
As suggested by Johannes here:
	#662 (comment)

Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
  • Loading branch information
rata committed Oct 5, 2020
1 parent 63a1ff9 commit 1c5acfd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion internal/speakerlist/speakerlist.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@ func New(logger gokitlog.Logger, nodeName, bindAddr, bindPort, secret, namespace
// while waiting for the join operation to complete.
sl.mlJoinCh = make(chan struct{}, 1)

// ChannelEventDelegate hint that it should not block, so make mlEventCh
// ChannelEventDelegate hints that it should not block, so make mlEventCh
// 'big'.
// TODO: See https://github.com/metallb/metallb/issues/716
sl.mlEventCh = make(chan memberlist.NodeEvent, 1024)
mconfig.Events = &memberlist.ChannelEventDelegate{Ch: sl.mlEventCh}

Expand Down

0 comments on commit 1c5acfd

Please sign in to comment.